search

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.7k stars 1.06k forks source link

Publish Microsoft.NET.TestFramework to nuget.org. #25303

Open AraHaan opened 2 years ago

AraHaan commented 2 years ago

Now that I know that Microsoft.NET.TestFramework exists and works for testing msbuild stuff (or sdk specific msbuild files) I could see the usefulness of using it to test any person's 3rd party .NET SDKs as well to ensure they set their msbuild attributes or w/e correctly.

I did not know about the ability to unit test msbuild stuff from it until my PR was tested to fix an issue in the msbuild files in the sdk (#24656).

It could also be used to offer unit testing of the other official SDKs the .NET Team offers as well I think too.

nohwnd commented 2 years ago

@AraHaan I am not familiar with that namespace. Is it part of dotnet sdk that you'd like to have published as separate package?

AraHaan commented 2 years ago

It's actually is an library the sdk uses to test the msbuild files that make up the .NET SDK, which can be useful to test other .NET SDK's that are shipped as nuget packages / with the .NET SDK installer.

Which would be great when it comes to ensuring that the SDKs that get used are properly done.

see: https://github.com/dotnet/sdk/tree/main/src/Tests/Microsoft.NET.TestFramework

nohwnd commented 2 years ago

Ok, thanks for the clarification. This is not dotnet test specific, so I will unassigned it from that label so it can be assigned to someone else who might decide about publishing this as a nuget.

My only advice would be to change the namespace to something different as it is similar to both Microsoft.NET.Test.SDK which is the nuget that powers .NET testing. And MSTest test framework, which turns up when you search for Microsoft Test Framework.

AraHaan commented 2 years ago

I agree, the namespace should be changed.