dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.59k stars 1.03k forks source link

Configure SAC to disabled upon install #38256

Open JanKrivanek opened 5 months ago

JanKrivanek commented 5 months ago

Blocked by: https://microsoft.visualstudio.com/OS/_workitems/edit/48660765

Context

Smart App Control curently performs cloud based monitoring in evaluation mode, intercepting I/Os on the machine and is able to detect a developer machine only upon some initial extended period (usually 24 - 72 hours) possibly slowing up an initial experience of users experimenting with new setup. We saw cases where users decided to revert their upgrades (OS/VS/SDK), thinking they lead to inferior performance (some details in linked ADO item). We are cooperating with Smart App Control team to allow client side check facilitated via registry key (yet to be defined). On the SDK and VS side we shoud take care about setting the key during install, to prevent the initial performance hit.

KalleOlaviNiemitalo commented 5 months ago

Does Smart App Control detect Developer Mode quickly?

JanKrivanek commented 5 months ago

Does Smart App Control detect Developer Mode quickly?

24 - 72 hours. Which might be longer than some users invest in evaluating new setup

JanKrivanek commented 5 months ago

Sorry I misread. Smart App Control currently has it's own way of determining the machine is a development machine (and that detection has the mentioned duration)

KalleOlaviNiemitalo commented 5 months ago

I meant, if a user has taken explicit action to enable Developer Mode, then I imagine Smart App Control could immediately take that as a reliable evidence rather than wait to collect more information. And the VS and .NET SDK installers could then recommend doing so.

JanKrivanek commented 5 months ago

That's correct and that's hopefully going to happen mid-/long- term. For short term we're only getting this way around.

nagilson commented 2 weeks ago

A spec was made on the VS Side... still waiting for the completion in VS of that spec.