Open dsplaisted opened 6 months ago
FYI @jaredpar @dotnet/nuget-team I'm disabling tests for using aliases with package references. I'm pretty sure this was a test issue but keep an eye out, it's possible this could have been an issue in NuGet, the compiler, or the .NET SDK.
Do we have tests in NuGet that we can think of as sufficient coverage here? Also is the binlog available when these tests fail?
@jaredpar - Here's aliases tests in NuGet.Client:
I don't know how these compare to the ones in the SDK repo, but disabling tests is scary.
@dsplaisted: Have you ensured that the tests run sequentially to discard parallelization issues?
cc @zivkan, @nkolev92
NuGet's alias test also only test the NuGet side of applying the aliases, ie we check the assets file. We don't really run a build, since that requires the full SDK, and we don't always have the latest version. I think it'd be great to keep the SDK side tests.
The tests in
GivenThatWeHaveAPackageReferenceWithAliases
have started failing somewhat consistently in CI. I haven't been able to reproduce the issue locally. The failures look something like this:This seems like it's probably a test issue, perhaps related to the fact that these tests create and then consume NuGet packages within the test. Because of this, I am going to disable these tests for now. To further investigate, we probably need to figure out how to get a binlog of the failures in Helix.
Known Issue Error Message
Fill the error message using step by step known issues guidance.
Report
Summary