Re-enable CanSortByDownloadCountAndThenByName Template Engine test

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI

https://dot.net/core

MIT License

2.59k stars 1.03k forks source link

Re-enable CanSortByDownloadCountAndThenByName Template Engine test #39772

Open baronfel opened 3 months ago

baronfel commented 3 months ago

We skipped it to unblock pipelines, but we need to figure out what changed. The output of the search cache could have changed (likely?), or the processing of the CLI output inside the test.

dotnet-issue-labeler[bot] commented 3 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

lewing commented 3 months ago

Looking at the history it appears the name comparer used in the test was changed a few days ago but the name by name assertion doesn't use the same ellipsis logic to handle shortened names. Strings differ\r\n ↓ (pos 0)\r\nExpected: "scottgeek.conso..."\r\nActual: "ScottGeek.Console"\r\n ↑ (pos 0)