dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.71k stars 1.07k forks source link

Implement DevDeviceId generation and transmission #42804

Closed baronfel closed 1 week ago

baronfel commented 2 months ago

Is your feature request related to a problem? Please describe.

We should implement DevDeviceId generation, following along with the python and golang implementations. We should send this field as the property DevDeviceId and we should not hash this value. We should investigate the behavior of this implementation under sudo and non-sudo use cases to make sure that we don't crash. If we cannot generate a value, we should send the property with an empty string.

KalleOlaviNiemitalo commented 2 months ago

Go-deviceid mentions "based on the DevDeviceId specification" but is the specification public?