search

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.72k stars 1.07k forks source link

Re-enable Microsoft.DotNet.Watcher.Tests.GlobbingAppTests.RenameCompiledFile and DeleteSourceFolder #42921

Open baronfel opened 2 months ago

baronfel commented 2 months ago

Describe the bug

I disabled these tests as part of https://github.com/dotnet/sdk/pull/42240 after they failed repeatedly in CI despite working locally on Windows and Linux systems. We should figure out what's up and re-enable them. The fix that worked for the remaining GlobbingAppTests that didn't need to be skipped was to strip Terminal Logger ANSI codes from the stdout of the app being run via dotnet run so that the simple string-based equality checks being done in the tests would work, but those do in fact work locally.

tmat commented 2 months ago

Test output for investigation: console.20a7f859.txt