search

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.75k stars 1.07k forks source link

Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878

Open marcpopMSFT opened 1 week ago

marcpopMSFT commented 1 week ago

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=869444 Build error leg or test failing: Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_WithConditions_BasedOnFileName Pull request: https://github.com/dotnet/sdk/pull/44859

Error Message

{
  "ErrorMessage": "57005",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=869444 Error message validated: [57005] Result validation: :white_check_mark: Known issue matched with the provided build. Validation performed at: 11/14/2024 7:41:30 PM UTC

Report

Build Definition Step Name Console log Pull Request
878965 dotnet/sdk Build Log dotnet/sdk#45123
877901 dotnet/sdk Build Log dotnet/sdk#44874
877550 dotnet/sdk Build Log dotnet/sdk#44874
877043 dotnet/sdk Build Log dotnet/sdk#45050
876723 dotnet/sdk Build Log dotnet/sdk#44874
876722 dotnet/sdk Build Log dotnet/sdk#45042
2586986 dotnet-sdk Build Log #45250
876318 dotnet/sdk Build Log dotnet/sdk#45033
876175 dotnet/sdk Build Log dotnet/sdk#44828
876076 dotnet/sdk Synchronize dotnet/dotnet (Unix) Log dotnet/sdk#45028
876022 dotnet/sdk Build Log dotnet/sdk#45025
875938 dotnet/sdk Run AoT Tests Log dotnet/sdk#45022
875288 dotnet/sdk Run TestBuild Tests Log dotnet/sdk#44786
874359 dotnet/sdk Build Log dotnet/sdk#44963
874130 dotnet/sdk Run FullFramework Tests Log dotnet/sdk#44570
2585028 dotnet-sdk Build Log
873187 dotnet/sdk Build Log dotnet/sdk#44924
873105 dotnet/sdk Run dotnet-format on dotnet/aspnetcore AspNetCore.sln Log dotnet/sdk#44801
872811 dotnet/sdk Build Log dotnet/sdk#44924
872605 dotnet/sdk Build Log dotnet/sdk#44899
872221 dotnet/sdk Build Log dotnet/sdk#44924
871493 dotnet/sdk Build Log dotnet/sdk#44874
870967 dotnet/sdk Build Log dotnet/sdk#44828
870895 dotnet/sdk Build Log dotnet/sdk#44874
870869 dotnet/sdk Build Log dotnet/sdk#44828
869919 dotnet/sdk Build Log dotnet/sdk#44874
870590 dotnet/sdk Build Log dotnet/sdk#44786
870426 dotnet/sdk Build Log dotnet/sdk#44786
Build Definition Test Pull Request
877905 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.DryRunRespectsTargetPathAndOutputDir dotnet/sdk#45088
2586915 dotnet-sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CannotOverwriteFilesWithoutForce #45249
875748 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddJsonProperty_WithMultipleAddJsonPropertyActions dotnet/sdk#43085
875140 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanShowMessageInCaseShortNameConflict
874735 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddPackageReference dotnet/sdk#43085
874351 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddProjectToSolution_Basic_Approval dotnet/sdk#44806
867820 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.RunScript_Basic_Approval dotnet/sdk#44806
873732 dotnet/sdk dotnet-watch.Tests.dll.1.WorkItemExecution dotnet/sdk#44540
873677 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddPackageReference
871957 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.Restore_WithOutputRelativePath dotnet/sdk#44866
873332 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate dotnet/sdk#44949
870891 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewUpdateTests.PrintInfoOnUpdateOnCreation dotnet/sdk#44889
871959 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddPackageReference_WithOutputAbsolutePath dotnet/sdk#44865
871495 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.MSBuildEvaluationTests.MultipleProjects_BasicTest dotnet/sdk#44906
871488 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddPackageReference dotnet/sdk#44904
871456 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddJsonProperty_FailsWhenJsonFileNotFound dotnet/sdk#43085
872042 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_ConditionalProcessing dotnet/sdk#44810
870729 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddJsonProperty_Basic dotnet/sdk#44885
871563 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.MSBuildEvaluationTests.MultipleProjects_BasicTest dotnet/sdk#44786
871558 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.RunScript_RedirectOnError dotnet/sdk#44907
871345 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.PostActions_DryRun dotnet/sdk#44691
871402 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddProjectToSolution_BasicInSolutionRoot dotnet/sdk#44900
871339 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.MSBuildEvaluationTests.Class_BasicTest dotnet/sdk#44899
871214 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.MSBuildEvaluationTests.TestClass_BasicTest dotnet/sdk#44730
871038 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.AddPackageReference_WithOutputAbsolutePath dotnet/sdk#44834
870979 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.Restore_Basic_Approval dotnet/sdk#44894
870754 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.RunScript_Basic dotnet/sdk#44850
870714 dotnet/sdk dotnet.Tests.dll.15.WorkItemExecution dotnet/sdk#44802
869923 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddPackageReference dotnet/sdk#44875
869898 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_MultiValueChoiceParameterExplicitlyUnset dotnet/sdk#44872
870619 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.MSBuildEvaluationTests.Class_BasicTest dotnet/sdk#44865
869653 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddProjectToSolution dotnet/sdk#44866
869908 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplateWithSecondShortName dotnet/sdk#44873
869444 dotnet/sdk Microsoft.DotNet.Cli.New.IntegrationTests.PostActionTests.ItCanCreateTemplate_WithAddProjectReference dotnet/sdk#44859

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
1 31 62
BrennanConroy commented 1 week ago

Template engine tests hitting known parallelism issue in GetVisualStudioInstances

Is there an issue describing the problem? Are there people working on fixing it? We're hitting this in the aspnetcore repo a lot and as far as I'm aware we don't do anything with UWP which is how the sdk resolved the problem.

baronfel commented 1 week ago

@jaredpar sent a PR here with a short-term workaround that we're working to merge: https://github.com/dotnet/sdk/pull/44930

The 'true' fix is coming in a future VS release, there was some unintended concurrent access to a critical section that wasn't locked.