search

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.74k stars 1.07k forks source link

Update vs-solutionpersistence to 1.0.23 #45018

Closed kasperk81 closed 1 hour ago

kasperk81 commented 1 day ago

@mthalman do we need another step after https://github.com/dotnet/source-build-externals/pull/409? still seeing

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24570.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.VisualStudio.SolutionPersistence.1.0.23
baronfel commented 1 day ago

might need to trigger a dependency flow of source-build-externals? the darc subscription is enabled, but might just need more time to flow through auto-updates.

mthalman commented 1 day ago

I triggered the subscription. This is the change you need: https://github.com/dotnet/sdk/pull/45020. I suspect both that change and this change need to be in the same PR in order to succeed.

kasperk81 commented 8 hours ago

this is ready. unblocks https://github.com/dotnet/sdk/pull/45040 and https://github.com/dotnet/sdk/pull/44570