dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.71k stars 1.07k forks source link

Migration: Null Ref #6810

Closed 333fred closed 4 years ago

333fred commented 8 years ago

Steps to reproduce

Attempting to migrate a project, linked here: https://github.com/333fred/NetworkTables/tree/migrate-null-ref/src/FRC.NetworkTables.Core. I ran the following from the src\FRC.NetworkTables.Core\ folder:

  1. dotnet restore
  2. dotnet migrate

Tagging @brthor.

Expected behavior

Migration performs successfully

Actual behavior

C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core [migrate ≡]> dotnet restore
log  : Restoring packages for C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\project.json...
log  : Restoring packages for C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\NetworkTables.Core.project.json...
log  : Lock file has not changed. Skipping lock file write. Path: C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\NetworkTables.Core.project.lock.json
log  : C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\NetworkTables.Core.project.json
log  : Restore completed in 64ms.
log  : Lock file has not changed. Skipping lock file write. Path: C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\project.lock.json
log  : C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core\project.json
log  : Restore completed in 122ms.
C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core [migrate ≡]> dotnet migrate
Object reference not set to an instance of an object.
C:\Users\frsilb\Documents\git\NetworkTables\src\FRC.NetworkTables.Core [migrate ≡]> dotnet --version
1.0.0-preview3-003553
brthor commented 8 years ago

I'll take a look at this today, thanks for the report @333fred

333fred commented 8 years ago

I tagged the specific commit so it's easy to get at, migrate-null-ref