dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
447 stars 84 forks source link

Refactor for dotnet/sign#650 #653

Closed dtivel closed 4 months ago

dtivel commented 5 months ago

CC @javierdlg, @clairernovotny

This change refactors a bit to facilitate #650 by:

  1. Replacing IKeyVaultService with more reusable interfaces ISignatureAlgorithmProvider and ICertificateProvider.
  2. Simplifying the ISigner interface, so that signature algorithm provider-specific arguments don't need to be passed. Instead, signature providers can just request ISignatureAlgorithmProvider and/or ICertificateProvider services. The implementations of those services are currently Key Vault but could be something else.