dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
447 stars 84 forks source link

Support for Azure Trusted Signing #683

Open EuanKerr opened 2 months ago

EuanKerr commented 2 months ago

With Azure Trusted Signing (formerly Azure Code Signing) now in public preview it would be handy to be able to sign files/clickonce using the Trusted Signing service.

Some more links:

dlemstra commented 1 month ago

Would love to see support for this. The @ImageMagick project has a Trusted Signing certificate and we are using this to sign our installers and executables. But there is no support for that in this tool yet. And I would like to also sign my ImageMagick NuGet packages using that certificate in a GitHub pipeline.

And feel free to let me know if there is anything I can do to help.

blowdart commented 1 month ago

Throwing my weight behind this as I have a new package I want to test with and I'm trying to keep everything in GitHub actions as an added bonus.

ROGG437063 commented 1 month ago

I am also supporting this request, our developers need to migrate to trusted signing, but without support for clickonce in any of the other trusted signing tools, that is not possible.

ROGG437063 commented 1 month ago

This integration should probably use the SDK https://www.nuget.org/packages/Microsoft.Trusted.Signing.Client Do take care that the SDK linked in trusted signing docs is deprecated

ianjmcm commented 1 month ago

@ROGG437063 sorry for the confusion on the docs regarding the SDK. We have kept the current version from our preview unlisted while we prep a new release of the SDK. This SDK will become publicly listed in the very near future. https://www.nuget.org/packages/Azure.CodeSigning.Sdk cc: @Jaxelr

Jaxelr commented 1 month ago

@ROGG437063 Indeed, we expect the SDK to be publicly available once we sort through a few issues on the PR, but you can track that work here: https://github.com/Azure/azure-sdk-for-net/pull/41191

ROGG437063 commented 4 weeks ago

@Jaxelr Sounds good, any estimate of when that will be merged? It would also still need integration with sign cli for vsto manifest signing, right?

demiliani commented 2 weeks ago

Must to have. Please push 🙌🏻

dtivel commented 4 days ago

This prerelease version has Trusted Signing support. Thanks to @dlemstra for adding it! 👏