dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
439 stars 84 forks source link

Moved the KeyVault services to their own library. #695

Closed dlemstra closed 3 weeks ago

dlemstra commented 3 weeks ago

This PR moves the KeyVaultService and KeyVaultServiceProvider to their own library. Moving this to it's own library will make it easier for someone to create their own sign.exe that only contains the services (and dependencies) that they need. I will create another PR to also move the CertificateStore services to their own library but there is an active PR making changes to it now so I will wait with that until that PR is merged. And once that is done I will also add a SignatureProvider for Trusted Signing.

I also noticed there were no unit tests for the classes that I moved so this PR also adds units for those two classes.

And I am wondering if some interfaces should be made public in the Sign.Core library to avoid adding those InternalsVisibleToAttribute everywhere but I kept everything internal for now.