search

dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
439 stars 84 forks source link

Localized file check-in by OneLocBuild Task: Build definition ID 1190: Build ID 2468224 #696

Closed dotnet-bot closed 3 weeks ago

dotnet-bot commented 3 weeks ago

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

dlemstra commented 3 weeks ago

It looks like this PR removed all the translations that I moved when I moved the resources. Did I forget to do something @dtivel to make sure the translations remain? I have looked at my PR again and I cannot figure out what I did incorrectly.

dtivel commented 2 weeks ago

@dlemstra, thanks for asking.

Our localization is handled by another team. Much of the localization process is automated. When resource strings are moved around, the loc process initially flags the "new" --- really, just moved --- resource strings as new and ready for translation. Then, normally within a day or so, the loc process realigns and reapplies previous translations. For some reason I don't know, this didn't happen within a day this time, so someone manually triggered the realignment and reapplication. The reapplied translations are here.

So, while strings may briefly go from translated to untranslated as a result of a move, they should also get retranslated shortly thereafter. You don't need to do anything special.

dlemstra commented 2 weeks ago

Thanks for the detailed explanation. Maybe a CONTRIBUTING.md could be added to this project with this information?

dtivel commented 2 weeks ago

@dlemstra, that's a great idea.