Renamed SignatureProvider to DataFormatSigner so SignatureProvider can be used by the new SignatureProvider libraries.

dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce

MIT License

439 stars 84 forks source link

Renamed SignatureProvider to DataFormatSigner so SignatureProvider can be used by the new SignatureProvider libraries. #700

Closed dlemstra closed 2 weeks ago

dlemstra commented 3 weeks ago

The name SignatureProvider is now use by the classes that are DataFormatSigners and we want this name to be used in the SignatureProvider libraries. Renaming all these classes and interfaces will make it possible to use this name.

dtivel commented 2 weeks ago

@clairernovotny, I was still reviewing this when it merged. :(

@dlemstra, can you please rename the folder https://github.com/dotnet/sign/tree/main/src/Sign.Core/SignatureProviders to DataFormatSigners?

clairernovotny commented 2 weeks ago

Eek, sorry!

dlemstra commented 2 weeks ago

@dtivel Would you be okay with me renaming that folder in a PR where I move the NuGetSigner to a separate library? Or would you like me to create a separate PR for this?

dlemstra commented 2 weeks ago

I noticed that there were some issues when moving the NuGetSigner to a separate library. One of the is an incorrect ILogger injection. To address this and your comment I created a PR to fix this. For the other issue I will create a separate PR.