Housekeeping - Githubissues

dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce

MIT License

439 stars 84 forks source link

Housekeeping #708

Closed dlemstra closed 2 weeks ago

dlemstra commented 2 weeks ago

This PR does some housekeeping to fix the following "issues":

Correct the ILogger injections and fields types.
Rename the folder that was mentioned as a review comment in #700.
Use a consistent constructor notation through the whole project.

dlemstra commented 2 weeks ago

Just realized that we could use $(MSBuildThisFileDirectory) for the value of RepositoryRootDirectory inside the Directory.Build.props file. Would it be okay to also add that to this PR?

dtivel commented 2 weeks ago

Just realized that we could use $(MSBuildThisFileDirectory) for the value of RepositoryRootDirectory inside the Directory.Build.props file. Would it be okay to also add that to this PR?

Sure, sounds good. Thanks, @dlemstra.

dlemstra commented 2 weeks ago

I have updated the PR and also included some changes to the .editorconfig because I kept getting tabs when pasting something in the .csproj files.