search

dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
439 stars 84 forks source link

Added support for Trusted Signing #716

Closed dlemstra closed 6 days ago

dlemstra commented 2 weeks ago

This PR adds support for Trusted Signing that was requested in #683 with the help of the Azure.CodeSigning.Sdk library.

dlemstra commented 2 weeks ago

The build is failing because if this error:

src\Sign.SignatureProviders.TrustedSigning\Sign.SignatureProviders.TrustedSigning.csproj(0,0): error NU1101: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Azure.CodeSigning.Sdk. No packages exist with this id in source(s): dotnet-8, dotnet-eng, dotnet-libraries, dotnet-public, dotnet-tools

I have this package in my local cache and that is why "it works on my machine". Which source should I add to make this work?

Jaxelr commented 2 weeks ago

@dlemstra Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

dlemstra commented 2 weeks ago

@dlemstra Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

The nuget.org feed is not included in the NuGet.Config file of this project. Wondering if I can add it?

dtivel commented 1 week ago

@dlemstra Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

The nuget.org feed is not included in the NuGet.Config file of this project. Wondering if I can add it?

No, see https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md. I followed those directions and mirrored the package.

I'm reviewing the rest of your PR.