search

dotnet / sign

Code Signing CLI tool supporting Authenticode, NuGet, VSIX, and ClickOnce
MIT License
477 stars 90 forks source link

Fix ClickOnce signing using Trusted Signing #736

Closed dlemstra closed 2 months ago

dlemstra commented 3 months ago

This PR fixes the issue that was reported in #735. There was an explicit cast to RSAKeyVault but this can be changed to RSA instead. I have updated a unit test to hit this "new" path and also removed an unnecessary duplicate check.

dtivel commented 3 months ago

@clairernovotny, do you want to review this?

JaapMosselman commented 2 months ago

Any estimation for the timeframe this PR will be released? Whould be nice if I don't have to use my own version.

dtivel commented 2 months ago

@JaapMosselman, https://www.nuget.org/packages/sign/0.9.1-beta.24361.2 has the fix. Happy signing!