search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
265 stars 130 forks source link

[ArPow Tarball] Generate Root Repo git-info #2250

Open dseefeld opened 3 years ago

dseefeld commented 3 years ago

The root repo (installer) doesn't have git-info because generation for that is in "clone dependent repo" and the info is generated from Version.Details.xml. There isn't sha and version information available for the the root repo. Where should this information exist? In current source-build, this comes from the version of Version.Details.xml in source-build since it is an overarching repo. In the current prototype, this information is hardcoded in src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets.

MichaelSimons commented 1 year ago

This would solve #3078.

crummel commented 1 year ago

In #3078 Omair mentioned grabbing the git tag from the current commit which seems plausible, although Logan notes that in 7.0 the tags have changed to include the unstabilized suffix so we'll have to account for that.