Closed MichaelSimons closed 3 years ago
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
@sfoslund, Can you provide some guidance on how this should be handled for source-build?
I believe @dsplaisted fixed this in recent builds, is that correct?
This does look like the failure that was fixed with https://github.com/dotnet/sdk/pull/21358.
However, I don't believe that it was right to disable including the workload manifests in source build. I think that will probably break installing the wasm-tools workload, as well as correctly failing to build projects that require a given workload.
The workload manifests should only include text files (json and MSBuild .targets files). Is there a way we can include them in source build, since it's more like source code delivered via a NuGet package rather than a prebuilt binary?
Thanks for responding @dsplaisted and @sfoslund, yes we could handle these the manifests as text-only packages that are included in source-build.
I don't know how you handle text-only packages, but you may want some validation that they only include text if you don't already have a process for that. The manifests are supposed to only have text, but someone could author them to include an MSBuild task DLL that the .targets would load.
Smoke-test fail with the following exception:
This is a regression caused by https://github.com/dotnet/installer/pull/12231