search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
265 stars 132 forks source link

Globally disable analyzer warnings in bootstrapping stage 2 build #3427

Open mthalman opened 1 year ago

mthalman commented 1 year ago

One of the frequent causes of failures in the bootstrapping stage 2 build is due to analyzer warnings (which are treated as errors). Recent examples of this are https://github.com/dotnet/installer/pull/16269 and https://github.com/dotnet/installer/pull/16268. Failing the build on these types of errors is problematic:

Failing on these errors also doesn't provide much value either since they really don't affect the functionality of the product.

We should consider globally disabling all analyzer warnings/errors for all repos built in source-build.

dotnet-issue-labeler[bot] commented 1 year ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

MichaelSimons commented 1 year ago

[Triage] This is also affecting stage 1 builds but they get surfaced in the dependency flow PRs before they are checked in.

MichaelSimons commented 1 year ago

I don't think this is going to reduce any source-build work rather it is just going to delay when the errors appear. If you suppress warnings as errors in stage 2, you will encounter then in the post release PRs that update the SDK to the latest version.