dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
265 stars 132 forks source link

Clean up sourcebuild tags in `sourcelink` dependencies #3551

Closed NikolaMilosavljevic closed 1 year ago

NikolaMilosavljevic commented 1 year ago

Contributes to https://github.com/dotnet/source-build/issues/3439

We should remove sourcelink package dependencies in all repos except sdk (for repo flow).

We should ensure that each repo uses the SDK that contains sourcelink, as specified in the aforementioned issue. SourceBuild tag should be kept in repos that use older SDK. For each of those repos, an issue should be created, to ensure the tag is removed when SDK gets updated. For many repos dependency is not even used and SDK update isn't needed.

Repos:

dotnet-issue-labeler[bot] commented 1 year ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

MichaelSimons commented 1 year ago

I think the sourcelink dependency should be removed entirely except for in the SDK repo. It only exists because it was a transitive dependency from using arcade.

NikolaMilosavljevic commented 1 year ago

Resolved all repos except command-line-api that is blocked - tracked with https://github.com/dotnet/command-line-api/issues/2264