search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
266 stars 132 forks source link

Investigate awkwardness around aspnetcore's repo tasks #3807

Open mmitche opened 10 months ago

mmitche commented 10 months ago

ASPNetCore builds a set of repo tasks as part of a pre-build script. The source-build infra inner build re-invokes the outer-build msbuild command with some extra args on the inner repo clone. This does not implicitly rebuild the repo tasks.

This is pretty awkward because it means that the source-build infra must be customized for aspnetcore in SourceBuild.props. It must first invoke a script that rebuilds the repo tasks before continuing with the build.

Are there better options? Why not just use standard project refs?

T-Shirt Size: Small (maybe not critical)

dotnet-issue-labeler[bot] commented 10 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ViktorHofer commented 10 months ago

Are there better options? Why not just use standard project refs?

I think it would be best to use msbuild's short lived task concept (which invokes tasks out-of-proc and then kills the task afterwards to free the lock on the assembly). We do that in runtime when invoking the live built linker.

ViktorHofer commented 10 months ago

cc @wtgodbe