dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
261 stars 128 forks source link

Repo binlogs should be copied to artifacts/log in the product build #4112

Open ViktorHofer opened 5 months ago

ViktorHofer commented 5 months ago

The current artifacts log layout is bizarre:

image

I think it would make more sense if the inner and outer repo build would put their binlog directly into the VMR's artifacts/log/<configuration>/ folder.

Example:

We will introduce a new environment variable that specifies the log folder to write into. If a repository produces more binlogs, they should respect that env var and write to that folder. I.e. fsharp

omajid commented 5 months ago

Is there an arcade/source-build variable that can be used to find the top-level artifacts/log directory from each repo? Or should we introduce the environment variable and then teach arcade to use that to set CurrentRepoSourceBuildBinlogFile?

ViktorHofer commented 5 months ago

Hey thanks for picking this up 👍 No, we don't yet have an env var for that. Naming suggestions? :)

omajid commented 5 months ago

Some random suggestions:

ViktorHofer commented 5 months ago

One more: DotNetBuildBinlogDir

Implies that this affects the product build and binlogs.