search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
266 stars 132 forks source link

Determine what to do with cross-apphosts in installer MSI builds #4114

Open mmitche opened 8 months ago

mmitche commented 8 months ago

When building SDK installers on x64 or x86, the apphost from arm64 and x86/x64 (alternate arch) are included. This won't be possible to do as-is in the VMR build, as those are built in different legs. This will require a build at the join point. There is some conjecture these can simply be removed, as they are for C++/CLI support when C++/CLI didn't support PackageReferences.

dotnet-issue-labeler[bot] commented 8 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

mmitche commented 8 months ago

/cc @ViktorHofer @jkoritzinsky @marcpopMSFT

mmitche commented 8 months ago

Part of #3739

marcpopMSFT commented 8 months ago

Note that package reference support is still not enabled by default for cppcli apps. If it were ever added, we could probably remove these as it would be able to download the app hosts by default. Note that all SDK tests today for cppCLI enable package reference support in the tests in order to download the apphosts in the test run (as the stage 2 and stage 0 runtimes don't match). @olgaark for plans around cppcli projects

ViktorHofer commented 2 weeks ago

Note that package reference support is still not enabled by default for cppcli apps

@marcpopMSFT do you know if this is still the case? Asking as we are now approaching this join point in the VMR.