Pass -productBuild switch from the VMR orchestrator to the repos instead of /p:DotNetBuildRepo=true

[ViktorHofer]

tools.ps1/sh might need to condition on whether the build is a product build. Tools.ps1/sh need to parse the $properties string array today which isn't great as not all repos set that. We should pass the -productBuild switch in when building the repos and then remove these code paths:

• https://github.com/dotnet/arcade/blob/6eb545ab682b04dc72cf574252b7843ec657dd99/eng/common/tools.ps1#L71
• https://github.com/dotnet/arcade/blob/6eb545ab682b04dc72cf574252b7843ec657dd99/eng/common/tools.ps1#L859 (the DotNetBuildRepo part)
• https://github.com/dotnet/arcade/blob/6eb545ab682b04dc72cf574252b7843ec657dd99/eng/common/tools.sh#L510 (the DotNetBuildRepo part)

[mmitche]

This is a good idea, though It will be necessary to implement this switch in any repo that has its own build entry point scripts:

• aspnetcore
• nuget.client
• roslyn
• fsharp?
• runtime

[ViktorHofer]

AFAIK only in the repos that don't forward switches to the Arcade build scripts. I.e. runtime just invokes eng/common/build.ps1/sh underneath and the switch should automatically be respected. AspNetCore doesn't do that and I assume they will need to react.