search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
257 stars 125 forks source link

Build output does not indicate build failures #4370

Open MichaelSimons opened 4 weeks ago

MichaelSimons commented 4 weeks ago

I was building in a devcontainer via ./build.sh -sb -bl. There was a build failure that I noticed in the build output scrolling by when watching the build yet nothing called out the build error when the build finished. 

  [14:54:31.60] Building razor...done
  New artifact(s) after building razor:
    -> Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal
    -> Microsoft.CodeAnalysis.Razor.Tooling.Internal
    -> Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
  [14:57:39.58] Building fsharp...done
  New artifact(s) after building fsharp:
    -> Microsoft.FSharp.Compiler
[root@codespaces-bb5a33 dotnet]# echo $?
1

Scrolling up in the build output I found the build error:

    /vmr/src/vstest/src/Microsoft.TestPlatform.CoreUtilities/GlobalSuppressions.cs(1,1): error IDE0073: A source file contains a header that does not match the required text (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073) [/vmr/src/vstest/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj::TargetFramework=net9.0]
##[error]/vmr/src/vstest/src/Microsoft.TestPlatform.CoreUtilities/GlobalSuppressions.cs(1,1): error IDE0073: (NETCORE_ENGINEERING_TELEMETRY=Build) A source file contains a header that does not match the required text (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073)

Is this something related to the parallel build infra?

dotnet-issue-labeler[bot] commented 4 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

MichaelSimons commented 3 weeks ago

[Triage] The expectation in this case is to at a minimum have text that clearly indicates the build failed. Optimally the build errors would be enumerated.