search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
257 stars 125 forks source link

New diagnostics binaries introduced into VMR #4375

Closed Winniexu01 closed 3 weeks ago

Winniexu01 commented 3 weeks ago

main build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2425948&view=logs&j=fa5c2909-0e29-5671-d5eb-16d6c40e0c4a&t=2a0bd486-3f67-5c59-da0c-b84d88848a4b

The Scan for binaries step is getting a warning from below newly introduced binary files:

20:29:23 dbug: BinaryTool[0] New binaries:
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/System.Diagnostics.StackTrace.dll
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/HelloWorld.pdb
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/libcoreclr.so.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/triagedump.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/minidump_x64.dmp.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/apphost.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/HelloWorld.exe
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/minidump_x86.dmp.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/libcoreclr.dylib.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/renamed_build_id_section
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/libclrjit.dylib.dwarf.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/ilasm.dbg
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/libcoreclrtraceptprovider.so.dbg.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/core.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.FileFormats.UnitTests/TestBinaries/PerfMapEnabled/System.ComponentModel.EventBasedAsync.dll
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/StackTraceSymbols.CoreCLR.cs.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/libSystem.Security.Cryptography.Native.Apple.dylib.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/md5_build_id
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/coreclr.dll.gz
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/stripped_executable
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/symbolized_executable
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/dir1/System.Threading.Thread.dll
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/dir1/System.Threading.Thread.pdb
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/dir2/System.Threading.Thread.dll
20:29:23 dbug: BinaryTool[0]     src/diagnostics/src/tests/Microsoft.SymbolStore.UnitTests/TestBinaries/dir2/System.Threading.Thread.pdb
20:29:23 fail: BinaryTool[0] ERROR: 25 new binaries. Check '/mnt/vss/_work/1/s/artifacts/log/binary-report/NewBinaries.txt' for details.
dotnet-issue-labeler[bot] commented 3 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ellahathaway commented 3 weeks ago

These are all test binaries, so they can be added to the vmr's allowed binaries.