Open omajid opened 1 month ago
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
Do you have a binlog that you can share?
It looks like the intent is to support this extension point, but the logic isn't right. It seems like there needs to be a ResolveIlToolPaths path for when the ToolPaths are specified.
[Triage] The logic appears broken. Either a custom path should be supported or the support that exists should be removed.
Describe the Bug
I am trying to override the ilasm and ildasm tools used by SBRP (while building as part of the VMR) to provide a custom implementation (for non-intel, non-arm platforms).
This section of msbuild looks like it supports providing an
ILAsmToolPath
property that can be used to override the ilasm tool used (it is used to setIlasmDir
). However, the code also errors out if it is set.https://github.com/dotnet/source-build-reference-packages/blob/a4c02499bef24d0e16255657ccdb160d26c82c32/src/targetPacks/Directory.Build.targets#L89-L110
When building, I get:
Is it supposed to be user-overrideable or not?