search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
261 stars 127 forks source link

Consider supporting CPM PackageVersion overrides #4467

Open ViktorHofer opened 3 weeks ago

ViktorHofer commented 3 weeks ago

Example: https://github.com/dotnet/templating/blob/5e4bdc5bb02e0fe73e4b962b85bc0f2dd97607de/Directory.Packages.props#L45-L57

That code block exists because the source-build / VMR infrastructure only overrides properties but not PackageVersion items for the corresponding package identities. This isn't a problem for versions that are updated by Maestro as it doesn't support CPM yet but for any package version that is directly listed in Directory.Packages.props it would be great if the infra could support such.

dotnet-issue-labeler[bot] commented 3 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 3 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ViktorHofer commented 1 week ago

@MichaelSimons @mmitche does anything speak against supporting this? If not, I would be willing to submit a PR.

MichaelSimons commented 1 week ago

Nothing is coming to mind as to why we shouldn't support this. It would help clean up several Directory.Packages.props files (example)and improve the UB/SB dev UX.