search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
261 stars 128 forks source link

VMR Stage 2 building failed in fsharp with package downgrade #4477

Closed Winniexu01 closed 2 weeks ago

Winniexu01 commented 3 weeks ago

Main build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2478805&view=logs&j=3121c41d-6088-53a5-4ef6-9a86f3460fe9&t=334539f4-dcef-5cad-a240-02997b3146e7

VMR Stage2 building fsharp failed with the following errors:

  /vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj : error NU1605: Detected package downgrade: System.Reflection.Metadata from 9.0.0-preview.6.24319.11 to 8.0.0. Reference the package directly from the project to select a different version. [/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##[error]/vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj(0,0): error NU1605: Detected package downgrade: System.Reflection.Metadata from 9.0.0-preview.6.24319.11 to 8.0.0. Reference the package directly from the project to select a different version.
  /vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj : error NU1605: fsc -> Microsoft.Build.Tasks.Core 17.11.0-preview-24318-05 -> System.Reflection.Metadata (>= 9.0.0-preview.6.24319.11) [/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##[error]/vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj(0,0): error NU1605: fsc -> Microsoft.Build.Tasks.Core 17.11.0-preview-24318-05 -> System.Reflection.Metadata (>= 9.0.0-preview.6.24319.11)
  /vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj : error NU1605: fsc -> System.Reflection.Metadata (>= 8.0.0) [/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##[error]/vmr/src/fsharp/src/fsc/fscProject/fsc.fsproj(0,0): error NU1605: fsc -> System.Reflection.Metadata (>= 8.0.0)
dotnet-issue-labeler[bot] commented 3 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 3 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

MichaelSimons commented 3 weeks ago

@ViktorHofer, can you take a look? TIA.

ViktorHofer commented 3 weeks ago

Interesting. I thought that https://github.com/dotnet/sdk/commit/05abdc5c0746c17290292897ca65a2e92e91f8de would prevent this. I would need to check why msbuild and runtime dependencies are still auto-upgraded.

ViktorHofer commented 2 weeks ago

Fixed via https://github.com/dotnet/fsharp/pull/17344. https://github.com/dotnet/sdk/pull/41788 fixes it for P6.

ViktorHofer commented 2 weeks ago

Reopening until the next source-build(-lite) build is green. The changes still need to flow into sdk.

ViktorHofer commented 2 weeks ago

Closing as fixed