dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
264 stars 129 forks source link

Stop producing git-info files #4491

Open omajid opened 2 months ago

omajid commented 2 months ago

This is a follow-up from https://github.com/dotnet/installer/pull/18941 (which was finally merged as https://github.com/dotnet/sdk/pull/41190)

@premun said:

I am only a bystander in this effort but once you are done with the whole feature change, can you please let me know and I can make the VMR synchronization tooling stop producing the git-info files?

I think we can do that now.

dotnet-issue-labeler[bot] commented 2 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 2 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ViktorHofer commented 2 months ago

cc @premun

ViktorHofer commented 2 months ago

@omajid I think the following lines still depend on the git-info files:

omajid commented 1 month ago

Uh, so deployment-tools.proj is something I can probably fix.

But as for OfficalBuildId and PrereleaseVersionLabel, I am not sure that was in scope of my original plan for fixing git commit hashes. I don't know of any way to obtain the values of those variables aside from these git-info files.

Maybe I should re-target this issue to just not recording commit hashes in git-info files?

ViktorHofer commented 1 month ago

Would be great if you could fix / standardize deployment-tools :)

Regarding OfficialBuildId / PrereleaseVersionLabel, I'm not actually sure. IIRC for most repos the idea is to use the OfficialBuildId calculated passed-in (either from AzDO or as a local arg). But we have some repos like roslyn which might need a different OfficialBuildId. cc @mmitche @MichaelSimons in case you remember

mmitche commented 1 month ago

For repos that need to have an official build id line up with another released product, the official build id is hardcoded into the repo state. IIRC we had another place this was recorded. For repos that only ship via the VMR, the OB ID can float (changes run to run). In that case it's provided via the CI system, and we will tell you what the number should be when you build, or more likely, we will simply make it so that it doesn't for product functionality whether everyone chooses the same ID. only major.minor.patch + prerelease label and iteration matter. Those are coded into the product sources.