search

dotnet / source-build

A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components
MIT License
266 stars 132 forks source link

Source-built / downloaded package detection warning in release/2.2 #772

Closed dseefeld closed 6 years ago

dseefeld commented 6 years ago

The following warning has appeared when building the release/2.2 branch:

/mnt/resource/j/workspace/dotnet_source-build/release_2.2/CentOS7.1_Release/repos/dir.targets(204,5): warning : Detected package id/version(s) in the cache that were source-built, but contents don't match. They were probably downloaded. See /mnt/resource/j/workspace/dotnet_source-build/release_2.2/CentOS7.1_Release/bin/conflict-report/before-templating/ for usage details. Microsoft.NETCore.ILAsm 2.2.0-preview2-26905-03, Microsoft.NETCore.ILDAsm 2.2.0-preview2-26905-03, Microsoft.NETCore.Jit 2.2.0-preview2-26905-03, Microsoft.NETCore.Runtime.CoreCLR 2.2.0-preview2-26905-03, Newtonsoft.Json 9.0.1 [/mnt/resource/j/workspace/dotnet_source-build/release_2.2/CentOS7.1_Release/repos/templating.proj]

The earliest PR this was detected in was https://github.com/dotnet/source-build/pull/761, although it could have been introduced earlier, since this was the last CI build available.

dagood commented 6 years ago

I linked this as a known issue in https://github.com/dotnet/source-build/releases/tag/v2.2.0-preview2.

Note that it doesn't affect offline tarball builds. The detected Microsoft.* packages are also only the identity packages, and I expect the runtimes are still source-built.

The Newtonsoft.Json issue is tracked by https://github.com/dotnet/source-build/issues/716 more specifically.

dagood commented 6 years ago

This is present in https://ci.dot.net/job/dotnet_source-build/job/release_2.2/job/RHEL7.2_Tarball_Release/9/ and not https://ci.dot.net/job/dotnet_source-build/job/release_2.2/job/RHEL7.2_Tarball_Release/10/, suggesting this went away with https://github.com/dotnet/source-build/commit/c5ec33217cc858491a0f969cc1fe86b504c0aca9. It doesn't happen with the current 2.2.0-preview3 PR https://github.com/dotnet/source-build/pull/821 either.

Closing as resolved.

It would be really nice to get on top of these better by turning them into errors. We just have to fix https://github.com/dotnet/source-build/issues/716 then we can do that.