search

dotnet / symstore

Implements API for retrieval of symbols and other debug artifacts from symbol store.
MIT License
143 stars 50 forks source link

Don't run Linux/Mac in official build #324

Closed mmitche closed 2 years ago

mikem8361 commented 2 years ago

Why? To save resources?

mmitche commented 2 years ago

We have to switch the pool usage in the official build to use 1ES pools, and these are already run in the rolling public CI.

mmitche commented 2 years ago

Official build test: https://dev.azure.com/dnceng/internal/_build/results?buildId=1584607&view=results

hoyosjs commented 2 years ago

@mikem8361 are there any tests that make it worth to build this outside of windows? AS far as I know, most of the tests run on top of blobs

mikem8361 commented 2 years ago

All the testing is the same (run against test assets checked in) regardless of the platform. So the official build doesn't need Linux/MacOS but I hope our check in CI will continue to build/test on them.

mmitche commented 2 years ago

All the testing is the same (run against test assets checked in) regardless of the platform. So the official build doesn't need Linux/MacOS but I hope our check in CI will continue to build/test on them.

Yes that will be the case.

ghost commented 2 years ago

Hello @hoyosjs!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.