search

dotnet / symstore

Implements API for retrieval of symbols and other debug artifacts from symbol store.
MIT License
142 stars 50 forks source link

Fix ELF build id key generator padding #391

Closed mikem8361 closed 1 year ago

mikem8361 commented 1 year ago

8 byte/64 bit build ids need to be padding to 20 bytes/160 bits according to spec.

mikem8361 commented 1 year ago

@hoyosjs ping

mikem8361 commented 1 year ago

Push the some review feedback just in case we want to take this change.

ghost commented 1 year ago

Hello @hoyosjs!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
ghost commented 1 year ago

Apologies, while this PR appears ready to be merged, it looks like main is a protected branch and I have not been granted permission to perform the merge.