search

dotnet / systemweb-adapters

MIT License
335 stars 61 forks source link

Exposing GetService method inside HttpContextWrapper #456

Closed birojnayak closed 8 months ago

birojnayak commented 9 months ago

Wanted to know if there is any limitation on exposing GetService method inside HttpContextWrapper reference source. This would help my porting effort in Webform as mentioned in the issue.

If there are no limitation, would be happy to contribute.

twsouthwick commented 9 months ago

Looks like HttpContextWrapper does not override HttpContextBase.GetService, so it should do that. Also, it may be worthwhile to update System.Web.HttpContext.GetService to delegate out to Microsoft.AspNetCore.Http.HttpContext.RequestServices so the IServiceProvider off of the System.Web.HttpContext types is actually useful

twsouthwick commented 9 months ago

@birojnayak I'm assigning this to you :)

twsouthwick commented 8 months ago

Fixed in #457