search

dotnet / templates

Templates for .NET
184 stars 59 forks source link

Fix EditorConfig at solution level #782

Closed beccamc closed 10 months ago

beccamc commented 11 months ago

Update the editor config creation flow to use the external access point provided by Roslyn.

templates_working

Also fixing this issue - https://github.com/dotnet/templates/issues/718

beccamc commented 11 months ago

@jasonmalinowski Could you take a look at this when you get a chance? I think you have the most context here and I'd love another set of eyes.

arunchndr commented 10 months ago

Retriggered the expired gates. Is this ready to go in?

beccamc commented 10 months ago

Now waiting on PR https://github.com/dotnet/roslyn/pull/71003

beccamc commented 10 months ago

This required the change from https://github.com/dotnet/roslyn/pull/71003. I manually tested with that change applied to VS, and the ExternalAccess point worked. This PR can go in.