search

dotnet / try-convert

Helping .NET developers port their projects to .NET Core!
MIT License
1.15k stars 153 forks source link

CodeAnalysis props are dropped on conversion #293

Open ryandle opened 4 years ago

ryandle commented 4 years ago

We converted some projects using --keep-current-tfms. It completes successfully without warning, but we noticed that the following props were quietly dropped / not included in the new sdk-style project. I would have expected at least a warning that these couldn't be converted.

<CodeAnalysisRuleSet>..\..\build\fxcop.ruleset</CodeAnalysisRuleSet>
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
jmarolf commented 4 years ago

This looks like a bug. we shouldn't remove ruleset items