search

dotnet / tye

Tye is a tool that makes developing, testing, and deploying microservices and distributed applications easier. Project Tye includes a local orchestrator to make developing microservices easier and the ability to deploy microservices to Kubernetes with minimal configuration.
MIT License
5.28k stars 520 forks source link

Authorization code (Identity Server part) is missing from the code #829

Open ffrankozz opened 3 years ago

ffrankozz commented 3 years ago

Hi, There is a video on youtube describing the Voting project as a showcase for Tye tool by two speakers (Justin Kotalik and Glen Condron). In the video, they also talk about Identity Server part for authorization attached to the sample code. However, I do not see it included in the relevant project here. If possible, could you please add that to the repo? Thank you.

Hammurabidoug commented 3 years ago

Yes. Seconded. There is an IdentityServer project in the jkotalik/newVotingSample branch, but it seems to be stale. There's also an exception thrown because it expects a public IP for the identity server.

ffrankozz commented 3 years ago

Yes. Seconded. There is an IdentityServer project in the jkotalik/newVotingSample branch, but it seems to be stale. There's also an exception thrown because it expects a public IP for the identity server.

Thank you. I later noticed that actually but I have not tried it yet. Probably we are supposed to place our identity server's IP for the public-ip's value obtained from docker network address(see docker settings, resources)

jkotalik commented 3 years ago

@frank-ozgul @Hammurabidoug yeah, the public IP expectation was something we didn't expect in our demo, and had to add it to make IdentityServer work. We didn't make it a sample because of that expectation. The IP address was actually the IP address of the k8s cluster.

Hammurabidoug commented 3 years ago

When I saw the IdentityServer demo, I was like “ yay! They figured out how to add dynamic OIDC redirect URIs.” But maybe I’m missing some of the magic of Tye. Will the sample include IdentityServer? I could not figure out how to get the Tye configuration to work with it. Otherwise I would have submitted a PR.

On Fri, Dec 18, 2020 at 12:25 PM Justin Kotalik notifications@github.com wrote:

@frank-ozgul https://github.com/frank-ozgul @Hammurabidoug https://github.com/Hammurabidoug yeah, the public IP expectation was something we didn't expect in our demo, and had to add it to make IdentityServer work. We didn't make it a sample because of that expectation. The IP address was actually the IP address of the k8s cluster.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dotnet/tye/issues/829#issuecomment-748217399, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMYLIU257BKPLVCXNMA3G3SVOGA3ANCNFSM4UFKIASQ .