Closed myokeeh closed 2 years ago
@ujjwalchadha Could you take a look?
Fixed by #1157 If this still persists, will reopen and take another look.
@ujjwalchadha, I just tried 0.3.331501 and it seems the Exception is now gone, but it still fails at this step:
[01:32:58 WRN] No code fix found for UA306_A1
[01:32:58 ERR] Failed to fix diagnostic UA306_A1 in C:\APP\Services\ViewLifetimeControl.cs
[01:32:58 WRN] Upgrade step Apply fix for [UA306_A1, UA306_A2, UA306_A3, UA306_A4, UA306_B, UA306_C, UA306_D, UA306_E, UA306_F, UA306_G, UA306_H, UA306_I]: Replace usage of Windows.UI.Core.CoreDispatcher, Replace usage of Window.Current.Dispatcher, Replace usage of App.Window.Dispatcher, Replace usage of Window.Dispatcher, Replace usage of Windows.Media.Capture.CameraCaptureUI, Replace usage of Micorsoft.UI.Xaml.Controls.InkCanvas, Replace usage of Microsoft.UI.Xaml.Controls.Maps.MapControl, Replace usage of Microsoft.UI.Xaml.Controls.MediaElement, Replace usage of Windows.Graphics.Printing.PrintManager, Replace usage of Windows.Security.Authentication.Web.WebAuthenticationBroker, Replace usage of Windows.UI.Xaml.Media.AcrylicBrush.BackgroundSource, Replace usage of Windows.UI.Shell.TaskbarManager failed: Failed: Failed to fix diagnostic UA306_A1 in C:\APP\Services\ViewLifetimeControl.cs
Command (Apply next step (Apply fix for [UA306_A1, UA306_A2, UA306_A3, UA306_A4, UA306_B, UA306_C, UA306_D, UA306_E, UA306_F, UA306_G, UA306_H, UA306_I]: Replace usage of Windows.UI.Core.CoreDispatcher, Replace usage of Window.Current.Dispatcher, Replace usage of App.Window.Dispatcher, Replace usage of Window.Dispatcher, Replace usage of Windows.Media.Capture.CameraCaptureUI, Replace usage of Micorsoft.UI.Xaml.Controls.InkCanvas, Replace usage of Microsoft.UI.Xaml.Controls.Maps.MapControl, Replace usage of Microsoft.UI.Xaml.Controls.MediaElement, Replace usage of Windows.Graphics.Printing.PrintManager, Replace usage of Windows.Security.Authentication.Web.WebAuthenticationBroker, Replace usage of Windows.UI.Xaml.Media.AcrylicBrush.BackgroundSource, Replace usage of Windows.UI.Shell.TaskbarManager)) did not succeed
Can you send the .clef
file that is generated in the project?
@ujjwalchadha upgrade-assistant.clef.txt
@myokeeh is it possible to send the repro code (The dispatcher queue related code in ViewLifetimeControl.cs) from the project that failed?
@ujjwalchadha this is the code that is generated by the tool as a result of the upgrade ViewLifetimeControl.cs.txt .
Thanks! Tracking the new issue here: #1171 Closing this one as it seems to be a separate issue.
Describe the bug
I'm trying out the UWP to WinUI3 upgrade, but it fails at the following step. The two solutions I've tried are ones made via Windows Template Studio (pre 5.0)
Exceptions (if any)
Further technical details
dotnet --list-sdks
3.1.419 [C:\Program Files\dotnet\sdk] 5.0.101 [C:\Program Files\dotnet\sdk] 5.0.103 [C:\Program Files\dotnet\sdk] 5.0.201 [C:\Program Files\dotnet\sdk] 5.0.214 [C:\Program Files\dotnet\sdk] 5.0.302 [C:\Program Files\dotnet\sdk] 6.0.105 [C:\Program Files\dotnet\sdk] 6.0.202 [C:\Program Files\dotnet\sdk] 6.0.203 [C:\Program Files\dotnet\sdk] 6.0.300 [C:\Program Files\dotnet\sdk]
upgrade-assistant --version
0.3.330701+fa00bab2d06aab9c710c344c0f32440ad4eb8410