search

dotnet / upgrade-assistant

A tool to assist developers in upgrading .NET Framework applications to .NET 6 and beyond
MIT License
1.1k stars 163 forks source link

Add support for API and Package mappings #1555

Closed jstedfast closed 4 months ago

jstedfast commented 5 months ago

Description

Adds support for 3rd-party API and Package mappings.

abpiskunov commented 4 months ago

not needed

Refers to: src/Microsoft.UpgradeAssistant.Mappings/Microsoft.UpgradeAssistant.Mappings.csproj:30 in 6f6cbb7. [](commit_id = 6f6cbb78689f26b7b3434285c3d756241f613b27, deletion_comment = False)

abpiskunov commented 4 months ago 
<Content Include="mappings\**\*.json">

You had some unit test project to test maps schema in this project?

Refers to: src/Microsoft.UpgradeAssistant.Mappings/Microsoft.UpgradeAssistant.Mappings.csproj:21 in 6f6cbb7. [](commit_id = 6f6cbb78689f26b7b3434285c3d756241f613b27, deletion_comment = False)

jstedfast commented 4 months ago 
<Content Include="mappings\**\*.json">

You had some unit test project to test maps schema in this project?

Yes, see the tests/ directory. The tests parse the JSON files and verify that they are syntactically correct values (as well as JSON, obviously).

mgoertz-msft commented 4 months ago

@abpiskunov I suspect that the dotnet.upgrade-assistant check does not complete because UA is no longer in this repo. Do you know where this check is marked as required and how to remove it?

gewarren commented 3 months ago

@jstedfast Is the binary analysis feature still supported? We were linking to the documentation for it from learn.microsoft.com, but now the link is broken and I'm not sure what to link to.

abpiskunov commented 3 months ago

binary analysis is supported however the CLI experience is different and our PMs are working on the blog post about that and learning docs. IN mean while new UA cli should guide you how to use new binary analysis.