UWP-WinUI migration issue - Githubissues

dotnet / upgrade-assistant

A tool to assist developers in upgrading .NET Framework applications to .NET 6 and beyond

MIT License

1.1k stars 163 forks source link

UWP-WinUI migration issue #1573

Open dotMorten opened 2 months ago

dotMorten commented 2 months ago

Describe the bug

Trying to create mappings for a UWP to WinUI package mapping, and having no luck and it ignores the package upgrade. Branch with changes here: https://github.com/dotMorten/upgrade-assistant/tree/arcgis_uwp/src/UpgradeAssistant.Mappings/mappings/Esri/Esri.ArcGISRuntime.UWP

To Reproduce

With the above branch for mappings, try and upgrade the following project: ArcGISApp1.zip You'll see the following error issue reported: This is even though the mapping has been explicitly defined here: https://github.com/dotMorten/upgrade-assistant/blob/arcgis_uwp/src/UpgradeAssistant.Mappings/mappings/Esri/Esri.ArcGISRuntime.UWP/esri.arcgisruntime.uwp.packagemap.json#L4

Further technical details

Windows version: Win11, 22H2 x64
Include the output of dotnet --list-sdks: 3.1.426, 8.0.300
Include the output of upgrade-assistant --version 0.5.678.21462

A similar issue also occurs with a Xamarin.Forms project, despite the mapping being defined for forms too: https://github.com/dotnet/upgrade-assistant/blob/14aba66d30ee78fff321a50dbad215b52a2dafa3/src/UpgradeAssistant.Mappings/mappings/Esri/Esri.ArcGISRuntime.Xamarin.Forms/esri.arcgisruntime.xamarin.forms.packagemap.json#L96

mgoertz-msft commented 2 months ago

The problem is that the report uses "net8.0" for its assessment when the project will be upgraded to "net8.0-windows10.0.19041.0". I opened a bug internally.