search

dotnet / vblang

The home for design of the Visual Basic .NET programming language and runtime library.
289 stars 66 forks source link

Updates to LDM Reviewed labels in this repository #315

Open KathleenDollard opened 6 years ago

KathleenDollard commented 6 years ago

We have begun reviewing issues (sorry this has been delayed). As part of this, we have added 4 new labels.

LDM In Process: LDM review is in progress LDM Considering: LDM reviewed and think this has merit LDM No Plans: LDM reviewed and this feature is unlikely to move forward in the foreseeable future LDM Rejected: LDM reviewed and rejected

To be honest, we struggled with the descriptions. The initial "LDM No Plans" was not sufficiently clear that we probably won't do it, at least not in the near term. Some of these are good ideas, they just don't align with our current review guidelines, which are in the 6/13 meeting notes., which also includes some of the guidelines we expect to use in reviewing issues.

ericmutta commented 6 years ago

The descriptions make sense to me and the transparency they afford is great!

One thing to consider is automatically closing/rejecting issues labeled No Plans for over a certain period (say 6 months?). When managing my task list, I have often found that if there's something I keep postponing again and again, it's usually because deep down I don't wanna do it because it's not that important. Closing/deleting the task after a while helps remove clutter and may serve the same purpose in this repo over time :+1:

PS: I would also personally like to encourage your team to use 'LDM Rejected' as often as necessary (and I say this as someone who's had some of my own ideas given that label, like #288). Getting things into a language is much easier than getting them out (case in point: On Error Resume ... still exists today!), so the bar should be very very high by default. This will not only keep the language clean, but will also make it a matter of pride to write a proposal so compelling that it makes it into the language for all eternity :muscle:

KathleenDollard commented 6 years ago

The bar will be high for adding things to the language. As you say, it's a permanent commitment.

But I'm not sure on closing issues. If someone is searching, do you think they will turn off the isactive part of the search?

For now, we'll leave it to people to close their own issues if they would like to withdraw, and otherwise not close. We will reconsider in 6 months (I think 6 months of no activity might be a good bar if we have a bar).