Open stewartadam opened 3 years ago
what about the one where it cannot find a symbol because the type doesn't exist, you add the type, error still there
Yes, not sure if that is related as in the above I'm seeing certain errors persist on files that are otherwise being analyzed, I think there may be a separate issue around namespace discovery (adding or moving files) where those files don't get included for analysis until Omnisharp restart.
Issue Description
Certain error types are reported by omnisharp but do not disappear when fixed; a manual restart or build is required to make omnisharp recognize the code is now valid.
I can reproduce with the BOM rule (SA1412) reliably; I've also seen it intermittently with newlines following opening brace (SA1505).
Steps to Reproduce
Expected Behavior
Omnisharp removes errors no longer present in codebase
Actual Behavior
Omnisharp hangs on to reported errors until next build
Logs
OmniSharp log
C# log
Environment information
VSCode version: 1.50.1 C# Extension: 1.23.5
Mono Information
OmniSharp using built-in monoDotnet Information
.NET Core SDK (reflecting any global.json): Version: 3.1.403 Commit: 9e895200cd Runtime Environment: OS Name: Mac OS X OS Version: 10.15 OS Platform: Darwin RID: osx.10.15-x64 Base Path: /usr/local/share/dotnet/sdk/3.1.403/ Host (useful for support): Version: 3.1.9 Commit: 774fc3d6a9 .NET Core SDKs installed: 3.1.403 [/usr/local/share/dotnet/sdk] .NET Core runtimes installed: Microsoft.AspNetCore.App 3.1.9 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App] Microsoft.NETCore.App 3.1.9 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App] To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-downloadVisual Studio Code Extensions
|Extension|Author|Version| |---|---|---| |aadb2c|AzureADB2CTools|1.2.93| |azure-account|ms-vscode|0.9.3| |azurerm-vscode-tools|msazurermtools|0.13.0| |code-spell-checker|streetsidesoftware|1.9.2| |cortex-debug|marus25|0.3.7| |cpptools|ms-vscode|1.0.1| |csharp|ms-dotnettools|1.23.5| |CursorColumnSelectOnTrueLines|martinzimmermannapps|0.0.2| |docomment|k--kato|0.1.18| |EditorConfig|EditorConfig|0.15.1| |gitlens|eamodio|10.2.3| |go|golang|0.18.1| |kubernetes-context|Okteto|0.1.0| |markdown-all-in-one|yzhang|3.3.0| |markdown-mermaid|bierner|1.8.1| |markdown-preview-enhanced|shd101wyy|0.5.13| |mssql|ms-mssql|1.9.0| |prettier-vscode|esbenp|5.7.1| |python|ms-python|2020.10.332292344| |remote-wsl|ms-vscode-remote|0.50.1| |scala|scala-lang|0.4.5| |sublime-keybindings|ms-vscode|4.0.7| |terraform|hashicorp|2.2.3| |vscode-azurefunctions|ms-azuretools|1.0.0| |vscode-azureresourcegroups|ms-azuretools|0.2.0| |vscode-azurestorage|ms-azuretools|0.11.0| |vscode-cosmosdb|ms-azuretools|0.15.0| |vscode-docker|ms-azuretools|1.7.0| |vscode-dotnet-adapter|derivitec-ltd|1.4.3| |vscode-dotnet-runtime|ms-dotnettools|0.1.2| |vscode-drawio|hediet|1.0.3| |vscode-html-css|ecmel|0.2.3| |vscode-icons|vscode-icons-team|11.0.0| |vscode-kubernetes-tools|ms-kubernetes-tools|1.2.1| |vscode-markdownlint|DavidAnson|0.37.2| |vscode-node-azure-pack|ms-vscode|0.0.11| |vscode-solution-explorer|fernandoescolar|0.3.11| |vscode-test-explorer|hbenl|2.19.1| |vscode-yaml|redhat|0.12.0| |vsliveshare|ms-vsliveshare|1.0.3121| |xml|DotJoshJohnson|2.5.1|;