dotnet / vscode-csharp

Official C# support for Visual Studio Code
MIT License
2.88k stars 676 forks source link

Syntax highlighting breaks after parenthesis in new line #4190

Closed webJose closed 2 weeks ago

webJose commented 4 years ago

Issue Description

Syntax highlighting fails for methods after constructor if the parenthesis are moved to a new line.

Steps to Reproduce

  1. Write a constructor with at least one parameter.
  2. Now format it so the opening parenthesis is in the next line.
  3. Now add a method after the constructor.

Expected Behavior

The lines after the constructor should have correct syntax highlighting. image

Actual Behavior

All text is white. image

Logs

OmniSharp log

Post the output from Output-->OmniSharp log here

C# log

Post the output from Output-->C# here

Environment information

VSCode version: 1.50.1 C# Extension: 1.23.5

Dotnet Information .NET Core SDK (reflecting any global.json): Version: 3.1.301 Commit: 7feb845744 Runtime Environment: OS Name: Windows OS Version: 10.0.18362 OS Platform: Windows RID: win10-x64 Base Path: C:\Program Files\dotnet\sdk\3.1.301\ Host (useful for support): Version: 3.1.5 Commit: 65cd789777 .NET Core SDKs installed: 2.1.201 [C:\Program Files\dotnet\sdk] 2.1.202 [C:\Program Files\dotnet\sdk] 2.1.502 [C:\Program Files\dotnet\sdk] 2.1.503 [C:\Program Files\dotnet\sdk] 2.1.505 [C:\Program Files\dotnet\sdk] 3.1.301 [C:\Program Files\dotnet\sdk] .NET Core runtimes installed: Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-download
Visual Studio Code Extensions |Extension|Author|Version| |---|---|---| |atlascode|atlassian|2.8.3| |cpptools|ms-vscode|1.1.0| |csharp|ms-dotnettools|1.23.5| |debugger-for-chrome|msjsdiag|4.12.11| |docomment|k--kato|0.1.18| |git-easy|bibhasdn|1.11.0| |git-graph|mhutchie|1.27.0| |gitlens|eamodio|10.2.3| |hexeditor|ms-vscode|1.3.0| |remote-wsl|ms-vscode-remote|0.50.1| |vscode-drawio|hediet|1.0.3| |vscode-eslint|dbaeumer|2.1.13| |vscode-language-pack-es|MS-CEINTL|1.50.2| |vscode-markdownlint|DavidAnson|0.37.2| |vscode-yaml|redhat|0.12.0|;
JoeRobich commented 2 weeks ago

The C# extension now supports semantic highlighting as well as an improved textmate grammar.

webJose commented 2 weeks ago

Does this mean that the bug is no longer present? Apologies, this was opened too long ago and I will need to search for the code that I had formatted this way.

JoeRobich commented 1 week ago

@webJose I have moved your issue to https://github.com/dotnet/csharp-tmLanguage/issues/326, which is the repository containing the C# textmate grammar. I can reproduce the highlight error when semantic highlighting is turned off. With semantic highlighting enabled I see Image

webJose commented 1 week ago

Hello, @JoeRobich . Thanks for the response. I see. Thank you very much for testing this out. I'll check out if I have it on or not.