dotnet / vscode-dotnet-runtime

VSCode Extension for Installing .NET via VS Code
MIT License
128 stars 229 forks source link

Version 2.0.2 caused that global config of VSC git client is ignored #1707

Open josch83 opened 3 months ago

josch83 commented 3 months ago

Describe the bug.

It was a struggle to narrow down the cause. Suddenly the git client stopped working because the user information and other configurations such as SSL were no longer known. A check of the global git configuration in the terminal showed that the configuration was still there. Deactivating the VSC extensions one after the other showed that the ".NET Install Tool" was the cause. Rolling back to version 2.0.1 fixed my problems.

I have no idea how this could happen with this extension, which has no obvious relation to Git.

Please attach log file(s) here if you have any.

The log file location should be copied to your clipboard if you came from VS Code.

Reproduction Steps

I did not check it on other environments, such I don't know if its reproducible.

  1. Clone a git repo in a terminal. In my case one with an invalid SSL certificate. Ensure that user name an email are configured in global config. Disable SSL validation globally if applicable (and undo it after the testing, of course).
  2. Open repo in VSC with extension installed (version 2.0.2)
  3. Try to fetch (SSL validation error) or commit changes (missing user email)

Expected Behavior

This extension should have no impact to git.

Exceptions & Errors (if any)

No response

.NET Install Tool Version

2.0.2

Your operating system? Please provide more detail, such as the version and or distro above.

Windows

VS Code Version

1.85.1 (user-setup)

josch83 commented 3 months ago

@meadowsjared reported a similar behaviour in isse #1686 : https://github.com/dotnet/vscode-dotnet-runtime/issues/1686#issuecomment-1979165653