dotnet / vscode-dotnet-runtime

VSCode Extension for Installing .NET via VS Code
MIT License
128 stars 230 forks source link

Protect against no versions of .NET to recommend #1768

Closed nagilson closed 2 months ago

nagilson commented 2 months ago

The API contract for returning a recommendedVersion is to return an IDotnetListVersionsResult which is an array of versions. If there are no packages of .NET available to install, we should have a specific message for that and return an empty array instead of what we do right now, which is:

a - returning a bad version b - returning undefined c - erroring out

I would ignore the earlier commits in the history. GitHub seems to be buggy today.

nagilson commented 2 months ago

Thank you! :)