search

dotnet / vscode-dotnet-runtime

VSCode Extension for Installing .NET via VS Code
MIT License
138 stars 256 forks source link

Update Axios Cache Interceptor Bundle for Runtime Error Change #1810

Closed nagilson closed 4 months ago

nagilson commented 4 months ago

Per the issue in https://github.com/arthurfiorette/tinylibs/issues/301, this is one of our highest facing issues. Let's see if this update resolves it.

This is to solve the issue reported in https://github.com/dotnet/vscode-dotnet-runtime/issues/1734 Failed: n[r].split is not a function. Abortion. Please ensure that you are online.

Along the way I also updated axios to make sure the newest version is utilized, and migrated to the newest version of vsce which is how we package our extension. In doing so, I had to migrate from node 16 to node 18.

joeloff commented 4 months ago

BTW, does the error message in the description contain a typo? Shouldn't it read Aborting?

joeloff commented 4 months ago

Are the lock files part of the PR or should they be excluded with .gitignore because they're artifacts from building locally?

nagilson commented 4 months ago

Yes, that string is old or doesnt come from our repo, nowadays its says aborting ;) but good catch!

https://github.com/dotnet/vscode-dotnet-runtime/blob/main/vscode-dotnet-runtime-library/src/Utils/WebRequestWorker.ts#L211

nagilson commented 4 months ago

Are the lock files part of the PR or should they be excluded with .gitignore because they're artifacts from building locally?

That's a good question. The standard convention is that the lock files should get checked in as it allows everyone to have a consistent build. We use yarn and npm and yarn bases its install off the lockfile, it is surprisingly tough to get the yarn file to match the npm file so deleting it or not maintaining them together would lose a lot of work.

https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

For the record I think every other vscode extension repo at msft does the same, and we all got there collectively on our own