dotnet / vscode-dotnet-runtime

VSCode Extension for Installing .NET via VS Code
MIT License
138 stars 256 forks source link

Improve Offline Message - [NETE2ESDK] Installing .NET 2.0-aspnetcore runtime failed with "No internet connection detected: Cannot install .NET " #1850

Open v-xiaofchen opened 3 months ago

v-xiaofchen commented 3 months ago

Describe the bug.

Installing .NET 2.0-aspnetcore runtime failed with "No internet connection detected: Cannot install .NET "

Reproduction Steps

1.Run the 'Sample: Acquire ASPNET runtime' or 'Sample: Acquire all 2.X ASPNET Runtimes Concurrent' command. You should be asked to enter a Major. Minor version, please enter 2.0. 2.observe the output

Expected Behavior

.NET 2.0-aspnetcore runtime installed successfully

Exceptions & Errors (if any)

Installing .NET 2.0-aspnetcore runtime failed with "No internet connection detected: Cannot install .NET " Sample: Acquire ASPNET runtime: image Sample: Acquire all 2.X ASPNET Runtimes Concurrent: image

.NET Install Tool Version

dotnet-install-tool-2.0.7

Your operating system? Please provide more detail, such as the version and or distro above.

N/A

VS Code Version

1.90.2

v-xiaofchen commented 3 months ago

This issue also repro on .NET 9.0-aspnetcore runtime image

nagilson commented 3 months ago

This is a good catch, thank you. The problem is that the server which hosts these files no longer has 2.0.9 on it, so it fails. The message should be improved, but its not an issue that this is no longer available via this method. For preview 5, I also think this is more of a server side issue not with this product.

Not a release blocker, leaving this open to fix offline message.

nagilson commented 1 month ago

This should be improved with a correct error message in the pending release

v-xiaofchen commented 1 month ago

On dotnet-install-tool-2.1.2, the error message is displayed as " .NET install time out ". image

nagilson commented 1 month ago

I think this is because 2.0.9 of aspnet does not exist anymore... this is the behavior I would expect now if the version does not exist.