dotnet / vscode-dotnet-runtime

VSCode Extension for Installing .NET via VS Code
MIT License
137 stars 261 forks source link

[NETE2ESDK] After downgrading the .NET Installer Tool, the .NET runtime download succeeds with errors. #1926

Closed v-xiaofchen closed 1 month ago

v-xiaofchen commented 2 months ago

Describe the bug.

After downgrading the .NET Installer Tool, the .NET runtime download succeeds with errors.

Reproduction Steps

1.Install version '2.1.2' of the .NET Installer Tool extension 2.Downgrade installation to a previous released version for example version '2.0.5', 3.Run the 'Sample: Acquire .NET Runtime' command for '5.0' and wait for it to finish 4.Observe

Expected Behavior

It should succeed without any errors.

Exceptions & Errors (if any)

The runtime download succeeds but an error occurs. image image

.NET Install Tool Version

2.1.2

Your operating system? Please provide more detail, such as the version and or distro above.

N/A

VS Code Version

1.92.2

Note

Can repro this issue on Windows11-x64 and Windows-arm64, Linux ubuntu-2204

nagilson commented 2 months ago

@v-xiaofchen @vsccarl This is only when downgrading the Extension, not upgrading, correct? (you can get to a clean state using uninstall all and starting from a lower version then going upwards.)

While not ideal, I understand why this is happening. And there is not really much we can do about it, we can't patch the older versions.

We could switch to a new data source for newer versions. Basically the data contains some new info that older extensions wont be able to operate on. Downgrading from any older version to another older version would still be broken, but not the newer ones if we did this. Not a release blocker.. as long as it's fine going in the other direction from old to new.

nagilson commented 2 months ago

I could not get this to happen when upgrading so I will not consider it a release blocker, we have some important fixes to get out.

v-xiaofchen commented 1 month ago

This issue did not recur when downgrading from version 2.1.6 to version 2.0.5. image

v-xiaofchen commented 1 month ago

Closed as fixed and not repro.