search

dotnet / wcf

This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.
MIT License
1.72k stars 558 forks source link

Stop splitting the UPN credential into username and domain parts unless specified #5663

Closed imcarolwang closed 1 week ago

mconnew commented 1 month ago

LGTM

mconnew commented 3 weeks ago

@imcarolwang, can you also check the behavior before explicitly setting the switch to validate the default too?

imcarolwang commented 3 weeks ago

@imcarolwang, can you also check the behavior before explicitly setting the switch to validate the default too?

Hi @mconnew, I’ve added the check for the default behavior before setting the switch value. Note: in the followed test variations, the switch is set using reflection since s_enableLegacyUpnUsernameFix is internal static and the AppContext.TryGetSwitch and assignment is invoked only once during the application's execution.